Commit 98f05b51 authored by Andy Lutomirski's avatar Andy Lutomirski Committed by Thomas Gleixner
Browse files

x86/entry/64: Use the TSS sp2 slot for SYSCALL/SYSRET scratch space 



In the non-trampoline SYSCALL64 path, a percpu variable is used to
temporarily store the user RSP value.

Instead of a separate variable, use the otherwise unused sp2 slot in the
TSS.  This will improve cache locality, as the sp1 slot is already used in
the same code to find the kernel stack.  It will also simplify a future
change to make the non-trampoline path work in PTI mode.

Signed-off-by: default avatarAndy Lutomirski <luto@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarBorislav Petkov <bp@suse.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/r/08e769a0023dbad4bac6f34f3631dbaf8ad59f4f.1536015544.git.luto@kernel.org
parent bd7b1f7c

arch/x86/entry/entry_64.S

+9 −7
Original line number Diff line number Diff line
@@ -215,13 +215,15 @@ ENTRY(entry_SYSCALL_64) 
	/*

	 * This path is only taken when PAGE_TABLE_ISOLATION is disabled so it

	 * is not required to switch CR3.

	 *

	 * tss.sp2 is scratch space.

	 */

	movq	%rsp, PER_CPU_VAR(rsp_scratch)

	movq	%rsp, PER_CPU_VAR(cpu_tss_rw + TSS_sp2)

	movq	PER_CPU_VAR(cpu_current_top_of_stack), %rsp



	/* Construct struct pt_regs on stack */

	pushq	$__USER_DS				/* pt_regs->ss */

	pushq	PER_CPU_VAR(rsp_scratch)	/* pt_regs->sp */

	pushq	PER_CPU_VAR(cpu_tss_rw + TSS_sp2)	/* pt_regs->sp */

	pushq	%r11					/* pt_regs->flags */

	pushq	$__USER_CS				/* pt_regs->cs */

	pushq	%rcx					/* pt_regs->ip */

arch/x86/include/asm/processor.h

+6 −0
Original line number Diff line number Diff line
@@ -315,7 +315,13 @@ struct x86_hw_tss { 
	 */

	u64			sp1;



	/*

	 * Since Linux does not use ring 2, the 'sp2' slot is unused by

	 * hardware.  entry_SYSCALL_64 uses it as scratch space to stash

	 * the user RSP value.

	 */

	u64			sp2;



	u64			reserved2;

	u64			ist[7];

	u32			reserved3;

arch/x86/kernel/asm-offsets.c

+2 −1
Original line number Diff line number Diff line
@@ -105,7 +105,8 @@ void common(void) { 
	DEFINE(SIZEOF_entry_stack, sizeof(struct entry_stack));

	DEFINE(MASK_entry_stack, (~(sizeof(struct entry_stack) - 1)));



	/* Offset for sp0 and sp1 into the tss_struct */

	/* Offset for fields in tss_struct */

	OFFSET(TSS_sp0, tss_struct, x86_tss.sp0);

	OFFSET(TSS_sp1, tss_struct, x86_tss.sp1);

	OFFSET(TSS_sp2, tss_struct, x86_tss.sp2);

}

arch/x86/kernel/process_64.c

+0 −2
Original line number Diff line number Diff line
@@ -59,8 +59,6 @@ 
#include <asm/unistd_32_ia32.h>

#endif



__visible DEFINE_PER_CPU(unsigned long, rsp_scratch);



/* Prints also some state that isn't saved in the pt_regs */

void __show_regs(struct pt_regs *regs, int all)

{

arch/x86/xen/xen-asm_64.S

+5 −3
Original line number Diff line number Diff line
@@ -91,13 +91,15 @@ ENTRY(xen_iret) 
ENTRY(xen_sysret64)

	/*

	 * We're already on the usermode stack at this point, but

	 * still with the kernel gs, so we can easily switch back

	 * still with the kernel gs, so we can easily switch back.

	 *

	 * tss.sp2 is scratch space.

	 */

	movq %rsp, PER_CPU_VAR(rsp_scratch)

	movq %rsp, PER_CPU_VAR(cpu_tss_rw + TSS_sp2)

	movq PER_CPU_VAR(cpu_current_top_of_stack), %rsp



	pushq $__USER_DS

	pushq PER_CPU_VAR(rsp_scratch)

	pushq PER_CPU_VAR(cpu_tss_rw + TSS_sp2)

	pushq %r11

	pushq $__USER_CS

	pushq %rcx