Commit 98e2727c authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

eth: stmmac: let page recycling happen with skbs 



stmmac removes pages from the page pool after attaching them
to skbs. Use page recycling instead.

skb heads are always copied, and pages are always from page
pool in this driver. We could as well mark all allocated skbs
for recycling.

Reviewed-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Link: https://lore.kernel.org/r/20230720010409.1967072-3-kuba@kernel.org


Reviewed-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b03f68ba

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+2 −2
Original line number Diff line number Diff line
@@ -5441,7 +5441,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) 
					priv->dma_conf.dma_buf_sz);



			/* Data payload appended into SKB */

			page_pool_release_page(rx_q->page_pool, buf->page);

			skb_mark_for_recycle(skb);

			buf->page = NULL;

		}
@@ -5453,7 +5453,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) 
					priv->dma_conf.dma_buf_sz);



			/* Data payload appended into SKB */

			page_pool_release_page(rx_q->page_pool, buf->sec_page);

			skb_mark_for_recycle(skb);

			buf->sec_page = NULL;

		}