Commit 98d67f25 authored by Hangyu Hua's avatar Hangyu Hua Committed by Benjamin Tissoires
Browse files

hid: hid-logitech-hidpp: avoid unnecessary assignments in hidpp_connect_event 



hidpp->delayed_input can't be assigned to an object that already call
input_free_device when input_register_device fails.

Fixes: c39e3d5f ("HID: logitech-hidpp: late bind the input device on wireless connection")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20220812025515.19467-1-hbh25y@gmail.com
parent 908d325e

drivers/hid/hid-logitech-hidpp.c

+3 −1
Original line number Diff line number Diff line
@@ -4007,8 +4007,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp) 
	hidpp_populate_input(hidpp, input);



	ret = input_register_device(input);

	if (ret)

	if (ret) {

		input_free_device(input);

		return;

	}



	hidpp->delayed_input = input;

}