Commit 98d46b02 authored by Felix Fietkau's avatar Felix Fietkau Committed by Johannes Berg
Browse files

Revert "mac80211: do not use low data rates for data frames with no ack flag" 



This reverts commit d3333223 ("mac80211: do not use low data rates for
data frames with no ack flag").

Returning false early in rate_control_send_low breaks sending broadcast
packets, since rate control will not select a rate for it.

Before re-introducing a fixed version of this patch, we should probably also
make some changes to rate control to be more conservative in selecting rates
for no-ack packets and also prevent using probing rates on them, since we won't
get any feedback.

Fixes: d3333223 ("mac80211: do not use low data rates for data frames with no ack flag")
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20210906083559.9109-1-nbd@nbd.name


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 977d293e

net/mac80211/rate.c

+0 −4
Original line number Diff line number Diff line
@@ -392,10 +392,6 @@ static bool rate_control_send_low(struct ieee80211_sta *pubsta, 
	int mcast_rate;

	bool use_basicrate = false;



	if (ieee80211_is_tx_data(txrc->skb) &&

	    info->flags & IEEE80211_TX_CTL_NO_ACK)

		return false;



	if (!pubsta || rc_no_data_or_no_ack_use_min(txrc)) {

		__rate_control_send_low(txrc->hw, sband, pubsta, info,

					txrc->rate_idx_mask);