Commit 98b0cf20 authored by Armin Wolf's avatar Armin Wolf Committed by Rafael J. Wysocki
Browse files

ACPI: battery: Call power_supply_changed() when adding hooks 



If a battery hook is added to a battery, userspace software
is not informed that the available properties of the battery
might have changed. This for example causes upower to react
slowly if a new battery hook is added during runtime.

Fix this by calling power_supply_changed() if a battery hook
was successfully added/removed.

Tested on a Dell Inspiron 3505.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b7b275e6

drivers/acpi/battery.c

+4 −1
Original line number Diff line number Diff line
@@ -696,7 +696,8 @@ static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock) 
	if (lock)

		mutex_lock(&hook_mutex);

	list_for_each_entry(battery, &acpi_battery_list, list) {

		hook->remove_battery(battery->bat);

		if (!hook->remove_battery(battery->bat))

			power_supply_changed(battery->bat);

	}

	list_del(&hook->list);

	if (lock)
@@ -735,6 +736,8 @@ void battery_hook_register(struct acpi_battery_hook *hook) 
			__battery_hook_unregister(hook, 0);

			goto end;

		}



		power_supply_changed(battery->bat);

	}

	pr_info("new extension: %s\n", hook->name);

end: