Commit 988d0d58 authored by Daniel Xu's avatar Daniel Xu Committed by Andrii Nakryiko
Browse files

bpf, test_run: Remove unnecessary prog type checks 



These checks were effectively noops b/c there's only one way these
functions get called: through prog_ops dispatching. And since there's no
other callers, we can be sure that `prog` is always the correct type.

Signed-off-by: default avatarDaniel Xu <dxu@dxuuu.xyz>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/0a9aaac329f76ddb17df1786b001117823ffefa5.1653855302.git.dxu@dxuuu.xyz
parent 9bbdfad8

net/bpf/test_run.c

+0 −6
Original line number Diff line number Diff line
@@ -1420,9 +1420,6 @@ int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog, 
	void *data;

	int ret;



	if (prog->type != BPF_PROG_TYPE_FLOW_DISSECTOR)

		return -EINVAL;



	if (kattr->test.flags || kattr->test.cpu || kattr->test.batch_size)

		return -EINVAL;
@@ -1487,9 +1484,6 @@ int bpf_prog_test_run_sk_lookup(struct bpf_prog *prog, const union bpf_attr *kat 
	u32 retval, duration;

	int ret = -EINVAL;



	if (prog->type != BPF_PROG_TYPE_SK_LOOKUP)

		return -EINVAL;



	if (kattr->test.flags || kattr->test.cpu || kattr->test.batch_size)

		return -EINVAL;