Commit 98829137 authored by Taniya Das's avatar Taniya Das Committed by Stephen Boyd
Browse files

clk: qcom: gcc-sc7180: Mark the camera abh clock always ON 



The camera clock controller requires the AHB clock, the driver when
moved to use the pm_runtime_get() API, the camera ahb clock failed turn
on before access, thus mark it as always ON.

Reported-by: default avatarStephen Boyd <sboyd@kernel.org>
Fixes: 8d402594 ("clk: qcom: camcc-sc7180: Use runtime PM ops instead of clk ones")
Signed-off-by: default avatarTaniya Das <tdas@codeaurora.org>
Link: https://lore.kernel.org/r/1608573816-1465-1-git-send-email-tdas@codeaurora.org


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 5c8fe583

drivers/clk/qcom/gcc-sc7180.c

+3 −18
Original line number Diff line number Diff line
@@ -891,21 +891,6 @@ static struct clk_branch gcc_boot_rom_ahb_clk = { 
	},

};



static struct clk_branch gcc_camera_ahb_clk = {

	.halt_reg = 0xb008,

	.halt_check = BRANCH_HALT,

	.hwcg_reg = 0xb008,

	.hwcg_bit = 1,

	.clkr = {

		.enable_reg = 0xb008,

		.enable_mask = BIT(0),

		.hw.init = &(struct clk_init_data){

			.name = "gcc_camera_ahb_clk",

			.ops = &clk_branch2_ops,

		},

	},

};



static struct clk_branch gcc_camera_hf_axi_clk = {

	.halt_reg = 0xb020,

	.halt_check = BRANCH_HALT,
@@ -2317,7 +2302,6 @@ static struct clk_regmap *gcc_sc7180_clocks[] = { 
	[GCC_AGGRE_UFS_PHY_AXI_CLK] = &gcc_aggre_ufs_phy_axi_clk.clkr,

	[GCC_AGGRE_USB3_PRIM_AXI_CLK] = &gcc_aggre_usb3_prim_axi_clk.clkr,

	[GCC_BOOT_ROM_AHB_CLK] = &gcc_boot_rom_ahb_clk.clkr,

	[GCC_CAMERA_AHB_CLK] = &gcc_camera_ahb_clk.clkr,

	[GCC_CAMERA_HF_AXI_CLK] = &gcc_camera_hf_axi_clk.clkr,

	[GCC_CAMERA_THROTTLE_HF_AXI_CLK] = &gcc_camera_throttle_hf_axi_clk.clkr,

	[GCC_CAMERA_XO_CLK] = &gcc_camera_xo_clk.clkr,
@@ -2519,11 +2503,12 @@ static int gcc_sc7180_probe(struct platform_device *pdev) 


	/*

	 * Keep the clocks always-ON

	 * GCC_CPUSS_GNOC_CLK, GCC_VIDEO_AHB_CLK, GCC_DISP_AHB_CLK

	 * GCC_GPU_CFG_AHB_CLK

	 * GCC_CPUSS_GNOC_CLK, GCC_VIDEO_AHB_CLK, GCC_CAMERA_AHB_CLK,

	 * GCC_DISP_AHB_CLK, GCC_GPU_CFG_AHB_CLK

	 */

	regmap_update_bits(regmap, 0x48004, BIT(0), BIT(0));

	regmap_update_bits(regmap, 0x0b004, BIT(0), BIT(0));

	regmap_update_bits(regmap, 0x0b008, BIT(0), BIT(0));

	regmap_update_bits(regmap, 0x0b00c, BIT(0), BIT(0));

	regmap_update_bits(regmap, 0x71004, BIT(0), BIT(0));