Commit 987d3560 authored by Mike McGowen's avatar Mike McGowen Committed by Martin K. Petersen
Browse files

scsi: smartpqi: Fix boot failure during LUN rebuild 

Move the delay in the register polling loop to the beginning of the loop to
ensure there is always a delay between writing the register and reading it.

Link: https://lore.kernel.org/r/20210928235442.201875-9-don.brace@microchip.com


Reviewed-by: default avatarScott Benesh <scott.benesh@microchip.com>
Reviewed-by: default avatarScott Teel <scott.teel@microchip.com>
Acked-by: default avatarJohn Donnelly <john.p.donnelly@oracle.com>
Signed-off-by: default avatarMike McGowen <Mike.McGowen@microchip.com>
Signed-off-by: default avatarDon Brace <don.brace@microchip.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 28ca6d87

drivers/scsi/smartpqi/smartpqi_init.c

+1 −1
Original line number Diff line number Diff line
@@ -4278,12 +4278,12 @@ static int pqi_create_admin_queues(struct pqi_ctrl_info *ctrl_info) 


	timeout = PQI_ADMIN_QUEUE_CREATE_TIMEOUT_JIFFIES + jiffies;

	while (1) {

		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);

		status = readb(&pqi_registers->function_and_status_code);

		if (status == PQI_STATUS_IDLE)

			break;

		if (time_after(jiffies, timeout))

			return -ETIMEDOUT;

		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);

	}



	/*