Commit 9858af27 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

usbip: Fix incorrect double assignment to udc->ud.tcp_rx 



Currently udc->ud.tcp_rx is being assigned twice, the second assignment
is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.

Fixes: 46613c9d ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
Acked-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210311104445.7811-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb9238e5

drivers/usb/usbip/vudc_sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev, 


		udc->ud.tcp_socket = socket;

		udc->ud.tcp_rx = tcp_rx;

		udc->ud.tcp_rx = tcp_tx;

		udc->ud.tcp_tx = tcp_tx;

		udc->ud.status = SDEV_ST_USED;



		spin_unlock_irq(&udc->ud.lock);