Commit 983f9101 authored by Nathan Lynch's avatar Nathan Lynch Committed by Michael Ellerman
Browse files

powerpc/cpuhp: BUG -> WARN conversion in offline path 



If, due to bugs elsewhere, we get into unregister_cpu_online() with a CPU
that isn't marked hotpluggable, we can emit a warning and return an
appropriate error instead of crashing.

Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: default avatarDaniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210927201933.76786-3-nathanl@linux.ibm.com
parent 7edd5c9a

arch/powerpc/kernel/sysfs.c

+2 −1
Original line number Diff line number Diff line
@@ -928,7 +928,8 @@ static int unregister_cpu_online(unsigned int cpu) 
	struct device_attribute *attrs, *pmc_attrs;

	int i, nattrs;



	BUG_ON(!c->hotpluggable);

	if (WARN_RATELIMIT(!c->hotpluggable, "cpu %d can't be offlined\n", cpu))

		return -EBUSY;



#ifdef CONFIG_PPC64

	if (cpu_has_feature(CPU_FTR_SMT))