Commit 982c5953 authored by Qing Wang's avatar Qing Wang Committed by Stephen Boyd
Browse files

clk-si5341: replace snprintf in show functions with sysfs_emit 



coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the following coccicheck warning:
drivers/clk/clk-si5341.c:1471: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1486: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1501: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1516: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280331-4150-1-git-send-email-wangqing@vivo.com


Reviewed-by: default avatarRobert Hancock <robert.hancock@calian.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 2a8b5394

drivers/clk/clk-si5341.c

+4 −4
Original line number Diff line number Diff line
@@ -1470,7 +1470,7 @@ static ssize_t input_present_show(struct device *dev, 
	if (res < 0)

		return res;

	res = !(status & SI5341_STATUS_LOSREF);

	return snprintf(buf, PAGE_SIZE, "%d\n", res);

	return sysfs_emit(buf, "%d\n", res);

}

static DEVICE_ATTR_RO(input_present);
@@ -1485,7 +1485,7 @@ static ssize_t input_present_sticky_show(struct device *dev, 
	if (res < 0)

		return res;

	res = !(status & SI5341_STATUS_LOSREF);

	return snprintf(buf, PAGE_SIZE, "%d\n", res);

	return sysfs_emit(buf, "%d\n", res);

}

static DEVICE_ATTR_RO(input_present_sticky);
@@ -1500,7 +1500,7 @@ static ssize_t pll_locked_show(struct device *dev, 
	if (res < 0)

		return res;

	res = !(status & SI5341_STATUS_LOL);

	return snprintf(buf, PAGE_SIZE, "%d\n", res);

	return sysfs_emit(buf, "%d\n", res);

}

static DEVICE_ATTR_RO(pll_locked);
@@ -1515,7 +1515,7 @@ static ssize_t pll_locked_sticky_show(struct device *dev, 
	if (res < 0)

		return res;

	res = !(status & SI5341_STATUS_LOL);

	return snprintf(buf, PAGE_SIZE, "%d\n", res);

	return sysfs_emit(buf, "%d\n", res);

}

static DEVICE_ATTR_RO(pll_locked_sticky);