Commit 982688c3 authored by Junxian Huang's avatar Junxian Huang Committed by ZhouJuan
Browse files

RDMA/hns: Fix incorrect post-send with direct wqe of wr-list in kernel space 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7A2SA



---------------------------------------------------------------

Currently, direct wqe is not supported for wr-list. RoCE driver excludes
direct wqe for wr-list by judging whether the number of wr is 1.

For a wr-list where the second wr is a length-error atomic wr, the
post-send driver handles the first wr and adds 1 to the wr number counter
firstly. While handling the second wr, the driver finds out a length error
and terminates the wr handle process, remaining the counter at 1. This
causes the driver mistakenly judges there is only 1 wr and thus enters
the direct wqe process, carrying the current length-error atomic wqe.

This patch fixes the error by adding a judgement whether the current wr
is a bad wr. If so, use the normal doorbell process but not direct wqe
despite the wr number is 1.

Fixes: a77e1f87 ("RDMA/hns: Remove the condition of light load for posting DWQE")
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
parent c0f88964

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+2 −1
Original line number Diff line number Diff line
@@ -863,7 +863,8 @@ static int hns_roce_v2_post_send(struct ib_qp *ibqp, 
		qp->sq.head += nreq;

		qp->next_sge = sge_idx;



		if (nreq == 1 && (qp->en_flags & HNS_ROCE_QP_CAP_DIRECT_WQE))

		if (nreq == 1 && !ret &&

		    (qp->en_flags & HNS_ROCE_QP_CAP_DIRECT_WQE))

			write_dwqe(hr_dev, qp, wqe);

		else

			update_sq_db(hr_dev, qp);