Commit 98175720 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: remove pointless sb_rdonly() checks from freezing code 



ext4_freeze() and ext4_unfreeze() checks for sb_rdonly(). However this
check is pointless as VFS already checks for read-only filesystem before
calling filesystem specific methods. Remove the pointless checks.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-1-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 1d401650

fs/ext4/super.c

+2 −7
Original line number Diff line number Diff line
@@ -6347,12 +6347,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait) 
static int ext4_freeze(struct super_block *sb)

{

	int error = 0;

	journal_t *journal;



	if (sb_rdonly(sb))

		return 0;



	journal = EXT4_SB(sb)->s_journal;

	journal_t *journal = EXT4_SB(sb)->s_journal;



	if (journal) {

		/* Now we set up the journal barrier. */
@@ -6386,7 +6381,7 @@ static int ext4_freeze(struct super_block *sb) 
 */

static int ext4_unfreeze(struct super_block *sb)

{

	if (sb_rdonly(sb) || ext4_forced_shutdown(EXT4_SB(sb)))

	if (ext4_forced_shutdown(EXT4_SB(sb)))

		return 0;



	if (EXT4_SB(sb)->s_journal) {