Commit 980d74e7 authored Oct 01, 2021 by Dan Carpenter Committed by Rob Clark Oct 11, 2021

drm/msm/a4xx: fix error handling in a4xx_gpu_init()



This code returns 1 on error instead of a negative error.  It leads to
an Oops in the caller.  A second problem is that the check for
"if (ret != -ENODATA)" cannot be true because "ret" is set to 1.

Fixes: 5785dd7a ("drm/msm: Fix duplicate gpu node in icc summary")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211001125759.GJ2283@kili


Signed-off-by: Rob Clark <robdclark@chromium.org>

parent 2133c4fc

drivers/gpu/drm/msm/adreno/a4xx_gpu.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -699,13 +699,14 @@ struct msm_gpu a4xx_gpu_init(struct drm_device dev)
		}

		icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
		ret = IS_ERR(icc_path);
		if (ret)
		if (IS_ERR(icc_path)) {
		ret = PTR_ERR(icc_path);
		goto fail;
		}

		ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem");
		ret = IS_ERR(ocmem_icc_path);
		if (ret) {
		if (IS_ERR(ocmem_icc_path)) {
		ret = PTR_ERR(ocmem_icc_path);
		/* allow -ENODATA, ocmem icc is optional */
		if (ret != -ENODATA)
		goto fail;