Commit 98025bce authored by Lijun Pan's avatar Lijun Pan Committed by Jakub Kicinski
Browse files

ibmvnic: notify peers when failover and migration happen 



Commit 61d3e1d9 ("ibmvnic: Remove netdev notify for failover resets")
excluded the failover case for notify call because it said
netdev_notify_peers() can cause network traffic to stall or halt.
Current testing does not show network traffic stall
or halt because of the notify call for failover event.
netdev_notify_peers may be used when a device wants to inform the
rest of the network about some sort of a reconfiguration
such as failover or migration.

It is unnecessary to call that in other events like
FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets
since in those scenarios the hardware does not change.
If the driver must do a hard reset, it is necessary to notify peers.

Fixes: 61d3e1d9 ("ibmvnic: Remove netdev notify for failover resets")
Suggested-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Suggested-by: default avatarPradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>
Signed-off-by: default avatarDany Madden <drt@linux.ibm.com>
Signed-off-by: default avatarLijun Pan <ljp@linux.ibm.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 83935975

drivers/net/ethernet/ibm/ibmvnic.c

+5 −1
Original line number Diff line number Diff line
@@ -2074,7 +2074,8 @@ static int do_reset(struct ibmvnic_adapter *adapter, 
	for (i = 0; i < adapter->req_rx_queues; i++)

		napi_schedule(&adapter->napi[i]);



	if (adapter->reset_reason != VNIC_RESET_FAILOVER) {

	if (adapter->reset_reason == VNIC_RESET_FAILOVER ||

	    adapter->reset_reason == VNIC_RESET_MOBILITY) {

		call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, netdev);

		call_netdevice_notifiers(NETDEV_RESEND_IGMP, netdev);

	}
@@ -2147,6 +2148,9 @@ static int do_hard_reset(struct ibmvnic_adapter *adapter, 
	if (rc)

		return IBMVNIC_OPEN_FAILED;



	call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, netdev);

	call_netdevice_notifiers(NETDEV_RESEND_IGMP, netdev);



	return 0;

}