Commit 979aa519 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by Saeed Mahameed
Browse files

net/mlx5: Fix variable type to match 64bit 



Fix the following smatch warning:
wait_func_handle_exec_timeout() warn: should '1 << ent->idx' be a 64 bit type?

Use 1ULL, to have a 64 bit type variable.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarEran Ben Elisha <eranbe@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 44f66ac9

drivers/net/ethernet/mellanox/mlx5/core/cmd.c

+4 −4
Original line number Diff line number Diff line
@@ -877,7 +877,7 @@ static void cb_timeout_handler(struct work_struct *work) 
	ent->ret = -ETIMEDOUT;

	mlx5_core_warn(dev, "cmd[%d]: %s(0x%x) Async, timeout. Will cause a leak of a command resource\n",

		       ent->idx, mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));

	mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);

	mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);



out:

	cmd_ent_put(ent); /* for the cmd_ent_get() took on schedule delayed work */
@@ -994,7 +994,7 @@ static void cmd_work_handler(struct work_struct *work) 
		MLX5_SET(mbox_out, ent->out, status, status);

		MLX5_SET(mbox_out, ent->out, syndrome, drv_synd);



		mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);

		mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);

		return;

	}
@@ -1008,7 +1008,7 @@ static void cmd_work_handler(struct work_struct *work) 
		poll_timeout(ent);

		/* make sure we read the descriptor after ownership is SW */

		rmb();

		mlx5_cmd_comp_handler(dev, 1UL << ent->idx, (ent->ret == -ETIMEDOUT));

		mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, (ent->ret == -ETIMEDOUT));

	}

}
@@ -1068,7 +1068,7 @@ static void wait_func_handle_exec_timeout(struct mlx5_core_dev *dev, 
		       mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));



	ent->ret = -ETIMEDOUT;

	mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);

	mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);

}



static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent)