Commit 979207ca authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: class: mark class_release() as taking a const * 



The struct class callback, class_release(), is only called in 2 places,
the pcmcia cardservices code, and in the class driver core code.  Both
places it is safe to mark the structure as a const *, to allow us to
in the future mark all struct class usages as constant and move into
read-only memory.

Acked-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Link: https://lore.kernel.org/r/2023040248-outrage-obsolete-5a9a@gregkh


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a131e337

drivers/base/class.c

+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ void class_unregister(const struct class *cls) 
}

EXPORT_SYMBOL_GPL(class_unregister);



static void class_create_release(struct class *cls)

static void class_create_release(const struct class *cls)

{

	pr_debug("%s called for %s\n", __func__, cls->name);

	kfree(cls);

drivers/pcmcia/cs.c

+1 −1
Original line number Diff line number Diff line
@@ -824,7 +824,7 @@ static int pcmcia_socket_uevent(const struct device *dev, 


static struct completion pcmcia_unload;



static void pcmcia_release_socket_class(struct class *data)

static void pcmcia_release_socket_class(const struct class *data)

{

	complete(&pcmcia_unload);

}

include/linux/device/class.h

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ struct class { 
	int (*dev_uevent)(const struct device *dev, struct kobj_uevent_env *env);

	char *(*devnode)(const struct device *dev, umode_t *mode);



	void (*class_release)(struct class *class);

	void (*class_release)(const struct class *class);

	void (*dev_release)(struct device *dev);



	int (*shutdown_pre)(struct device *dev);