Commit 978ce583 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

KVM: SVM: always update CR3 in VMCB 



svm_load_mmu_pgd is delaying the write of GUEST_CR3 to prepare_vmcs02 as
an optimization, but this is only correct before the nested vmentry.
If userspace is modifying CR3 with KVM_SET_SREGS after the VM has
already been put in guest mode, the value of CR3 will not be updated.
Remove the optimization, which almost never triggers anyway.
This was was added in commit 689f3bf2 ("KVM: x86: unify callbacks
to load paging root", 2020-03-16) just to keep the two vendor-specific
modules closer, but we'll fix VMX too.

Fixes: 689f3bf2 ("KVM: x86: unify callbacks to load paging root")
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 5b672408

arch/x86/kvm/svm/nested.c

+1 −5
Original line number Diff line number Diff line
@@ -256,10 +256,6 @@ void enter_svm_guest_mode(struct vcpu_svm *svm, u64 vmcb_gpa, 
	svm_set_efer(&svm->vcpu, nested_vmcb->save.efer);

	svm_set_cr0(&svm->vcpu, nested_vmcb->save.cr0);

	svm_set_cr4(&svm->vcpu, nested_vmcb->save.cr4);

	if (npt_enabled) {

		svm->vmcb->save.cr3 = nested_vmcb->save.cr3;

		svm->vcpu.arch.cr3 = nested_vmcb->save.cr3;

	} else

	(void)kvm_set_cr3(&svm->vcpu, nested_vmcb->save.cr3);



	/* Guest paging mode is active - reset mmu */

arch/x86/kvm/svm/svm.c

+5 −11
Original line number Diff line number Diff line
@@ -3447,7 +3447,6 @@ static fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu) 
static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root)

{

	struct vcpu_svm *svm = to_svm(vcpu);

	bool update_guest_cr3 = true;

	unsigned long cr3;



	cr3 = __sme_set(root);
@@ -3456,19 +3455,14 @@ static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root) 
		mark_dirty(svm->vmcb, VMCB_NPT);



		/* Loading L2's CR3 is handled by enter_svm_guest_mode.  */

		if (is_guest_mode(vcpu))

			update_guest_cr3 = false;

		else if (test_bit(VCPU_EXREG_CR3, (ulong *)&vcpu->arch.regs_avail))

		if (!test_bit(VCPU_EXREG_CR3, (ulong *)&vcpu->arch.regs_avail))

			return;

		cr3 = vcpu->arch.cr3;

		else /* CR3 is already up-to-date.  */

			update_guest_cr3 = false;

	}



	if (update_guest_cr3) {

	svm->vmcb->save.cr3 = cr3;

	mark_dirty(svm->vmcb, VMCB_CR);

}

}



static int is_disabled(void)

{