Commit 9735bde3 authored Dec 09, 2022 by Fenghua Yu Committed by Vinod Koul Dec 28, 2022

dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0



On DSA/IAX 1.0, TC-A and TC-B in GRPCFG are set as 1 to have best
performance and cannot be changed through sysfs knobs unless override
option is given.

The same values should be set on DSA 2.0 as well.

Fixes: ea7c8f59 ("dmaengine: idxd: restore traffic class defaults after wq reset")
Fixes: ade8a86b ("dmaengine: idxd: Set defaults for GRPCFG traffic class")
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20221209172141.562648-1-fenghua.yu@intel.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 5840c891

drivers/dma/idxd/device.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -701,7 +701,7 @@ static void idxd_groups_clear_state(struct idxd_device *idxd)
		group->use_rdbuf_limit = false;
		group->rdbufs_allowed = 0;
		group->rdbufs_reserved = 0;
		if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) {
		if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
		group->tc_a = 1;
		group->tc_b = 1;
		} else {

drivers/dma/idxd/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -295,7 +295,7 @@ static int idxd_setup_groups(struct idxd_device *idxd)
		}

		idxd->groups[i] = group;
		if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) {
		if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
		group->tc_a = 1;
		group->tc_b = 1;
		} else {

drivers/dma/idxd/sysfs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -387,7 +387,7 @@ static ssize_t group_traffic_class_a_store(struct device *dev,
		if (idxd->state == IDXD_DEV_ENABLED)
		return -EPERM;

		if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override)
		if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
		return -EPERM;

		if (val < 0 \|\| val > 7)
		@@ -429,7 +429,7 @@ static ssize_t group_traffic_class_b_store(struct device *dev,
		if (idxd->state == IDXD_DEV_ENABLED)
		return -EPERM;

		if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override)
		if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
		return -EPERM;

		if (val < 0 \|\| val > 7)