Commit 97140614 authored by Giovanni Cabiddu's avatar Giovanni Cabiddu Committed by Herbert Xu
Browse files

crypto: qat - add param check for RSA 



Reject requests with a source buffer that is bigger than the size of the
key. This is to prevent a possible integer underflow that might happen
when copying the source scatterlist into a linear buffer.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarAdam Guerin <adam.guerin@intel.com>
Reviewed-by: default avatarWojciech Ziemba <wojciech.ziemba@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 029aa462

drivers/crypto/qat/qat_common/qat_asym_algs.c

+8 −0
Original line number Diff line number Diff line
@@ -656,6 +656,10 @@ static int qat_rsa_enc(struct akcipher_request *req) 
		req->dst_len = ctx->key_sz;

		return -EOVERFLOW;

	}



	if (req->src_len > ctx->key_sz)

		return -EINVAL;



	memset(msg, '\0', sizeof(*msg));

	ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET(msg->pke_hdr,

					  ICP_QAT_FW_COMN_REQ_FLAG_SET);
@@ -785,6 +789,10 @@ static int qat_rsa_dec(struct akcipher_request *req) 
		req->dst_len = ctx->key_sz;

		return -EOVERFLOW;

	}



	if (req->src_len > ctx->key_sz)

		return -EINVAL;



	memset(msg, '\0', sizeof(*msg));

	ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET(msg->pke_hdr,

					  ICP_QAT_FW_COMN_REQ_FLAG_SET);