Commit 9710631c authored by Christian König's avatar Christian König
Browse files

drm: add drm_exec selftests v4 



Exercise at least all driver facing functions of this new component.

v2: add array test as well
v3: some kunit cleanups
v4: more tests and cleanups

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230711133122.3710-3-christian.koenig@amd.com
parent 09593216

drivers/gpu/drm/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -80,6 +80,7 @@ config DRM_KUNIT_TEST 
	select DRM_BUDDY

	select DRM_EXPORT_FOR_TESTS if m

	select DRM_KUNIT_TEST_HELPERS

	select DRM_EXEC

	default KUNIT_ALL_TESTS

	help

	  This builds unit tests for DRM. This option is not useful for

drivers/gpu/drm/tests/Makefile

+2 −1
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ 
	drm_modes_test.o \

	drm_plane_helper_test.o \

	drm_probe_helper_test.o \

	drm_rect_test.o

	drm_rect_test.o	\

	drm_exec_test.o



CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)

drivers/gpu/drm/tests/drm_exec_test.c

0 → 100644
+159 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: MIT

/*

 * Copyright 2022 Advanced Micro Devices, Inc.

 */



#define pr_fmt(fmt) "drm_exec: " fmt



#include <kunit/test.h>



#include <linux/module.h>

#include <linux/prime_numbers.h>



#include <drm/drm_exec.h>

#include <drm/drm_device.h>

#include <drm/drm_gem.h>



#include "../lib/drm_random.h"



static struct drm_device dev;



static void sanitycheck(struct kunit *test)

{

	struct drm_exec exec;



	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);

	drm_exec_fini(&exec);

	KUNIT_SUCCEED(test);

}



static void test_lock(struct kunit *test)

{

	struct drm_gem_object gobj = { };

	struct drm_exec exec;

	int ret;



	drm_gem_private_object_init(&dev, &gobj, PAGE_SIZE);



	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);

	drm_exec_until_all_locked(&exec) {

		ret = drm_exec_lock_obj(&exec, &gobj);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;

	}

	drm_exec_fini(&exec);

}



static void test_lock_unlock(struct kunit *test)

{

	struct drm_gem_object gobj = { };

	struct drm_exec exec;

	int ret;



	drm_gem_private_object_init(&dev, &gobj, PAGE_SIZE);



	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);

	drm_exec_until_all_locked(&exec) {

		ret = drm_exec_lock_obj(&exec, &gobj);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;



		drm_exec_unlock_obj(&exec, &gobj);

		ret = drm_exec_lock_obj(&exec, &gobj);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;

	}

	drm_exec_fini(&exec);

}



static void test_duplicates(struct kunit *test)

{

	struct drm_gem_object gobj = { };

	struct drm_exec exec;

	int ret;



	drm_gem_private_object_init(&dev, &gobj, PAGE_SIZE);



	drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES);

	drm_exec_until_all_locked(&exec) {

		ret = drm_exec_lock_obj(&exec, &gobj);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;



		ret = drm_exec_lock_obj(&exec, &gobj);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;

	}

	drm_exec_unlock_obj(&exec, &gobj);

	drm_exec_fini(&exec);

}







static void test_prepare(struct kunit *test)

{

	struct drm_gem_object gobj = { };

	struct drm_exec exec;

	int ret;



	drm_gem_private_object_init(&dev, &gobj, PAGE_SIZE);



	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);

	drm_exec_until_all_locked(&exec) {

		ret = drm_exec_prepare_obj(&exec, &gobj, 1);

		drm_exec_retry_on_contention(&exec);

		KUNIT_EXPECT_EQ(test, ret, 0);

		if (ret)

			break;

	}

	drm_exec_fini(&exec);

}



static void test_prepare_array(struct kunit *test)

{

	struct drm_gem_object gobj1 = { };

	struct drm_gem_object gobj2 = { };

	struct drm_gem_object *array[] = { &gobj1, &gobj2 };

	struct drm_exec exec;

	int ret;



	drm_gem_private_object_init(&dev, &gobj1, PAGE_SIZE);

	drm_gem_private_object_init(&dev, &gobj2, PAGE_SIZE);



	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);

	drm_exec_until_all_locked(&exec)

		ret = drm_exec_prepare_array(&exec, array, ARRAY_SIZE(array),

					     1);

	KUNIT_EXPECT_EQ(test, ret, 0);

	drm_exec_fini(&exec);

}



static struct kunit_case drm_exec_tests[] = {

	KUNIT_CASE(sanitycheck),

	KUNIT_CASE(test_lock),

	KUNIT_CASE(test_lock_unlock),

	KUNIT_CASE(test_duplicates),

	KUNIT_CASE(test_prepare),

	KUNIT_CASE(test_prepare_array),

	{}

};



static struct kunit_suite drm_exec_test_suite = {

	.name = "drm_exec",

	.test_cases = drm_exec_tests,

};



kunit_test_suite(drm_exec_test_suite);



MODULE_AUTHOR("AMD");

MODULE_LICENSE("GPL and additional rights");