Commit 970675f6 authored by Dong Aisheng's avatar Dong Aisheng Committed by Bjorn Andersson
Browse files

remoteproc: Fix the wrong default value of is_iomem 



Currently the is_iomem is a random value in the stack which may
be default to true even on those platforms that not use iomem to
store firmware.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: 40df0a91 ("remoteproc: add is_iomem to da_to_va")
Reviewed-and-tested-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210910090621.3073540-3-peng.fan@oss.nxp.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 24acbd9d

drivers/remoteproc/remoteproc_coredump.c

+1 −1
Original line number Diff line number Diff line
@@ -152,8 +152,8 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest, 
			       struct rproc_dump_segment *segment,

			       size_t offset, size_t size)

{

	bool is_iomem = false;

	void *ptr;

	bool is_iomem;



	if (segment->dump) {

		segment->dump(rproc, segment, dest, offset, size);

drivers/remoteproc/remoteproc_elf_loader.c

+1 −1
Original line number Diff line number Diff line
@@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) 
		u64 filesz = elf_phdr_get_p_filesz(class, phdr);

		u64 offset = elf_phdr_get_p_offset(class, phdr);

		u32 type = elf_phdr_get_p_type(class, phdr);

		bool is_iomem = false;

		void *ptr;

		bool is_iomem;



		if (type != PT_LOAD)

			continue;