Commit 96e45e52 authored by Colin Ian King's avatar Colin Ian King Committed by Thierry Reding
Browse files

pwm: ep93xx: Fix read of uninitialized variable ret 



There is a potential path in function ep93xx_pwm_apply where ret is
never assigned a value and it is checked for an error code. Fix this
by ensuring ret is zero'd in the success path to avoid this issue.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: f6ef94edf0f6 ("pwm: ep93xx: Unfold legacy callbacks into ep93xx_pwm_apply()")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent b235f8a3

drivers/pwm/pwm-ep93xx.c

+1 −0
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
				writew(duty_cycles, base + EP93XX_PWMx_DUTY_CYCLE);

				writew(period_cycles, base + EP93XX_PWMx_TERM_COUNT);

			}

			ret = 0;

		} else {

			ret = -EINVAL;

		}