Commit 96bdd4b9 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Validate vlan protocol ID on RX packets 



Only pass supported VLAN protocol IDs for stripped VLAN tags to the
stack.  The stack will hit WARN() if the protocol ID is unsupported.

Existing firmware sets up the chip to strip 0x8100, 0x88a8, 0x9100.
Only the 1st two protocols are supported by the kernel.

Fixes: a196e96b ("bnxt_en: clean up VLAN feature bit handling")
Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3958b1da

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+16 −5
Original line number Diff line number Diff line
@@ -1671,11 +1671,16 @@ static inline struct sk_buff *bnxt_tpa_end(struct bnxt *bp, 


	if ((tpa_info->flags2 & RX_CMP_FLAGS2_META_FORMAT_VLAN) &&

	    (skb->dev->features & BNXT_HW_FEATURE_VLAN_ALL_RX)) {

		u16 vlan_proto = tpa_info->metadata >>

			RX_CMP_FLAGS2_METADATA_TPID_SFT;

		__be16 vlan_proto = htons(tpa_info->metadata >>

					  RX_CMP_FLAGS2_METADATA_TPID_SFT);

		u16 vtag = tpa_info->metadata & RX_CMP_FLAGS2_METADATA_TCI_MASK;



		__vlan_hwaccel_put_tag(skb, htons(vlan_proto), vtag);

		if (eth_type_vlan(vlan_proto)) {

			__vlan_hwaccel_put_tag(skb, vlan_proto, vtag);

		} else {

			dev_kfree_skb(skb);

			return NULL;

		}

	}



	skb_checksum_none_assert(skb);
@@ -1897,9 +1902,15 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, 
	    (skb->dev->features & BNXT_HW_FEATURE_VLAN_ALL_RX)) {

		u32 meta_data = le32_to_cpu(rxcmp1->rx_cmp_meta_data);

		u16 vtag = meta_data & RX_CMP_FLAGS2_METADATA_TCI_MASK;

		u16 vlan_proto = meta_data >> RX_CMP_FLAGS2_METADATA_TPID_SFT;

		__be16 vlan_proto = htons(meta_data >>

					  RX_CMP_FLAGS2_METADATA_TPID_SFT);



		__vlan_hwaccel_put_tag(skb, htons(vlan_proto), vtag);

		if (eth_type_vlan(vlan_proto)) {

			__vlan_hwaccel_put_tag(skb, vlan_proto, vtag);

		} else {

			dev_kfree_skb(skb);

			goto next_rx;

		}

	}



	skb_checksum_none_assert(skb);