Commit 96b57229 authored by Jack Xu's avatar Jack Xu Committed by Herbert Xu
Browse files

crypto: qat - check return code of qat_hal_rd_rel_reg() 



Check the return code of the function qat_hal_rd_rel_reg() and return it
to the caller.

This is to fix the following warning when compiling the driver with
clang scan-build:

    drivers/crypto/qat/qat_common/qat_hal.c:1436:2: warning: 6th function call argument is an uninitialized value

Signed-off-by: default avatarJack Xu <jack.xu@intel.com>
Co-developed-by: default avatarZhehui Xiang <zhehui.xiang@intel.com>
Signed-off-by: default avatarZhehui Xiang <zhehui.xiang@intel.com>
Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 78b4267a

drivers/crypto/qat/qat_common/qat_hal.c

+5 −1
Original line number Diff line number Diff line
@@ -1417,7 +1417,11 @@ static int qat_hal_put_rel_wr_xfer(struct icp_qat_fw_loader_handle *handle, 
		pr_err("QAT: bad xfrAddr=0x%x\n", xfr_addr);

		return -EINVAL;

	}

	qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval);

	status = qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval);

	if (status) {

		pr_err("QAT: failed to read register");

		return status;

	}

	gpr_addr = qat_hal_get_reg_addr(ICP_GPB_REL, gprnum);

	data16low = 0xffff & data;

	data16hi = 0xffff & (data >> 0x10);