Commit 96836a35 authored by Jean Delvare's avatar Jean Delvare Committed by Lee Jones
Browse files

mfd: Drop obsolete dependencies on COMPILE_TEST 



Since commit 0166dc11 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

As a minor optimization, this also lets us drop of_match_ptr(), as we
now know what it will resolve to, we might as well save cpp some work.

Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Cc: Lee Jones <lee@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221122154134.58a7a18b@endymion.delvare
parent 7ef5c577

drivers/mfd/Kconfig

+8 −8
Original line number Diff line number Diff line
@@ -797,7 +797,7 @@ config MFD_MAX14577 
config MFD_MAX77620

	bool "Maxim Semiconductor MAX77620 and MAX20024 PMIC Support"

	depends on I2C=y

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	select REGMAP_IRQ
@@ -812,7 +812,7 @@ config MFD_MAX77620 
config MFD_MAX77650

	tristate "Maxim MAX77650/77651 PMIC Support"

	depends on I2C

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	select REGMAP_IRQ
@@ -827,7 +827,7 @@ config MFD_MAX77650 
config MFD_MAX77686

	tristate "Maxim Semiconductor MAX77686/802 PMIC Support"

	depends on I2C

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	select REGMAP_IRQ
@@ -856,7 +856,7 @@ config MFD_MAX77693 
config MFD_MAX77714

	tristate "Maxim Semiconductor MAX77714 PMIC Support"

	depends on I2C

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	help
@@ -1013,7 +1013,7 @@ config EZX_PCAP 
config MFD_CPCAP

	tristate "Support for Motorola CPCAP"

	depends on SPI

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_SPI

	select REGMAP_IRQ
@@ -1038,7 +1038,7 @@ config MFD_VIPERBOARD 


config MFD_NTXEC

	tristate "Netronix embedded controller (EC)"

	depends on OF || COMPILE_TEST

	depends on OF

	depends on I2C

	select REGMAP_I2C

	select MFD_CORE
@@ -1234,7 +1234,7 @@ config MFD_RN5T618 
config MFD_SEC_CORE

	tristate "Samsung Electronics PMIC Series Support"

	depends on I2C=y

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	select REGMAP_IRQ
@@ -2082,7 +2082,7 @@ config MFD_STPMIC1 
config MFD_STMFX

	tristate "Support for STMicroelectronics Multi-Function eXpander (STMFX)"

	depends on I2C

	depends on OF || COMPILE_TEST

	depends on OF

	select MFD_CORE

	select REGMAP_I2C

	help

drivers/mfd/motorola-cpcap.c

+1 −1
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ static int cpcap_probe(struct spi_device *spi) 
	struct cpcap_ddata *cpcap;

	int ret;



	match = of_match_device(of_match_ptr(cpcap_of_match), &spi->dev);

	match = of_match_device(cpcap_of_match, &spi->dev);

	if (!match)

		return -ENODEV;