Commit 966fdadf authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: aic94xx: Document 'lseq' and repair asd_update_port_links() header 

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/aic94xx/aic94xx_seq.c:587: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mip'
 drivers/scsi/aic94xx/aic94xx_seq.c:674: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mdp'
 drivers/scsi/aic94xx/aic94xx_seq.c:958: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_cio'
 drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Function parameter or member 'asd_ha' not described in 'asd_update_port_links'
 drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Function parameter or member 'phy' not described in 'asd_update_port_links'
 drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Excess function parameter 'sas_phy' description in 'asd_update_port_links'

Link: https://lore.kernel.org/r/20200713080001.128044-7-lee.jones@linaro.org


Cc: Luben Tuikov <luben_tuikov@adaptec.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 71aa4d3e

drivers/scsi/aic94xx/aic94xx_seq.c

+5 −1
Original line number Diff line number Diff line
@@ -582,6 +582,7 @@ static void asd_init_cseq_scratch(struct asd_ha_struct *asd_ha) 
/**

 * asd_init_lseq_mip -- initialize LSEQ Mode independent pages 0-3

 * @asd_ha: pointer to host adapter structure

 * @lseq:  link sequencer

 */

static void asd_init_lseq_mip(struct asd_ha_struct *asd_ha, u8 lseq)

{
@@ -669,6 +670,7 @@ static void asd_init_lseq_mip(struct asd_ha_struct *asd_ha, u8 lseq) 
/**

 * asd_init_lseq_mdp -- initialize LSEQ mode dependent pages.

 * @asd_ha: pointer to host adapter structure

 * @lseq:  link sequencer

 */

static void asd_init_lseq_mdp(struct asd_ha_struct *asd_ha,  int lseq)

{
@@ -953,6 +955,7 @@ static void asd_init_cseq_cio(struct asd_ha_struct *asd_ha) 
/**

 * asd_init_lseq_cio -- initialize LmSEQ CIO registers

 * @asd_ha: pointer to host adapter structure

 * @lseq:  link sequencer

 */

static void asd_init_lseq_cio(struct asd_ha_struct *asd_ha, int lseq)

{
@@ -1345,7 +1348,8 @@ int asd_start_seqs(struct asd_ha_struct *asd_ha) 


/**

 * asd_update_port_links -- update port_map_by_links and phy_is_up

 * @sas_phy: pointer to the phy which has been added to a port

 * @asd_ha: pointer to host adapter structure

 * @phy: pointer to the phy which has been added to a port

 *

 * 1) When a link reset has completed and we got BYTES DMAED with a

 * valid frame we call this function for that phy, to indicate that