Commit 966b8266 authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: fix boolreturn.cocci warning and rename function 



check_fcs() was returning bool as 0/1, which was a sign that the sense
 of the function was unclear: false was good, which doesn't really match
 a name like 'check_$thing'.  So rename it to ef100_has_fcs_error(), and
 use proper booleans in the return statements.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 59ebb430

drivers/net/ethernet/sfc/ef100_rx.c

+4 −4
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ bool ef100_rx_buf_hash_valid(const u8 *prefix) 
	return PREFIX_FIELD(prefix, RSS_HASH_VALID);

}



static bool check_fcs(struct efx_channel *channel, u32 *prefix)

static bool ef100_has_fcs_error(struct efx_channel *channel, u32 *prefix)

{

	u16 rxclass;

	u8 l2status;
@@ -46,11 +46,11 @@ static bool check_fcs(struct efx_channel *channel, u32 *prefix) 


	if (likely(l2status == ESE_GZ_RH_HCLASS_L2_STATUS_OK))

		/* Everything is ok */

		return 0;

		return false;



	if (l2status == ESE_GZ_RH_HCLASS_L2_STATUS_FCS_ERR)

		channel->n_rx_eth_crc_err++;

	return 1;

	return true;

}



void __ef100_rx_packet(struct efx_channel *channel)
@@ -63,7 +63,7 @@ void __ef100_rx_packet(struct efx_channel *channel) 


	prefix = (u32 *)(eh - ESE_GZ_RX_PKT_PREFIX_LEN);



	if (check_fcs(channel, prefix) &&

	if (ef100_has_fcs_error(channel, prefix) &&

	    unlikely(!(efx->net_dev->features & NETIF_F_RXALL)))

		goto out;