Commit 9666cec3 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: Drop function pwmchip_add_with_polarity() 



pwmchip_add() only calls pwmchip_add_with_polarity() and nothing else. All
other users of pwmchip_add_with_polarity() are gone. So drop
pwmchip_add_with_polarity() and move the code instead to pwmchip_add().

The initial assignment to pwm->state.polarity is dropped. In every correct
usage of the PWM API this value is overwritten later anyhow.

Signed-off-by: default avatarUwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 965ebe39

drivers/pwm/core.c

+3 −22
Original line number Diff line number Diff line
@@ -250,17 +250,14 @@ static bool pwm_ops_check(const struct pwm_chip *chip) 
}



/**

 * pwmchip_add_with_polarity() - register a new PWM chip

 * pwmchip_add() - register a new PWM chip

 * @chip: the PWM chip to add

 * @polarity: initial polarity of PWM channels

 *

 * Register a new PWM chip. The initial polarity for all channels is specified

 * by the @polarity parameter.

 * Register a new PWM chip.

 *

 * Returns: 0 on success or a negative error code on failure.

 */

int pwmchip_add_with_polarity(struct pwm_chip *chip,

			      enum pwm_polarity polarity)

int pwmchip_add(struct pwm_chip *chip)

{

	struct pwm_device *pwm;

	unsigned int i;
@@ -292,7 +289,6 @@ int pwmchip_add_with_polarity(struct pwm_chip *chip, 
		pwm->chip = chip;

		pwm->pwm = chip->base + i;

		pwm->hwpwm = i;

		pwm->state.polarity = polarity;



		radix_tree_insert(&pwm_tree, pwm->pwm, pwm);

	}
@@ -315,21 +311,6 @@ int pwmchip_add_with_polarity(struct pwm_chip *chip, 


	return ret;

}

EXPORT_SYMBOL_GPL(pwmchip_add_with_polarity);



/**

 * pwmchip_add() - register a new PWM chip

 * @chip: the PWM chip to add

 *

 * Register a new PWM chip. If chip->base < 0 then a dynamically assigned base

 * will be used. The initial polarity for all channels is normal.

 *

 * Returns: 0 on success or a negative error code on failure.

 */

int pwmchip_add(struct pwm_chip *chip)

{

	return pwmchip_add_with_polarity(chip, PWM_POLARITY_NORMAL);

}

EXPORT_SYMBOL_GPL(pwmchip_add);



/**

include/linux/pwm.h

+0 −2
Original line number Diff line number Diff line
@@ -392,8 +392,6 @@ int pwm_capture(struct pwm_device *pwm, struct pwm_capture *result, 
int pwm_set_chip_data(struct pwm_device *pwm, void *data);

void *pwm_get_chip_data(struct pwm_device *pwm);



int pwmchip_add_with_polarity(struct pwm_chip *chip,

			      enum pwm_polarity polarity);

int pwmchip_add(struct pwm_chip *chip);

int pwmchip_remove(struct pwm_chip *chip);

struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,