Commit 965b8b2b authored by Zheng Yongjun's avatar Zheng Yongjun Committed by David S. Miller
Browse files

net: dsa: simplify the return rtl8366_vlan_prepare() 



Simplify the return expression.

Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f2d5cf9

drivers/net/dsa/rtl8366.c

+1 −6
Original line number Diff line number Diff line
@@ -384,7 +384,6 @@ int rtl8366_vlan_prepare(struct dsa_switch *ds, int port, 
{

	struct realtek_smi *smi = ds->priv;

	u16 vid;

	int ret;



	for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++)

		if (!smi->ops->is_vlan_valid(smi, vid))
@@ -397,11 +396,7 @@ int rtl8366_vlan_prepare(struct dsa_switch *ds, int port, 
	 * FIXME: what's with this 4k business?

	 * Just rtl8366_enable_vlan() seems inconclusive.

	 */

	ret = rtl8366_enable_vlan4k(smi, true);

	if (ret)

		return ret;



	return 0;

	return rtl8366_enable_vlan4k(smi, true);

}

EXPORT_SYMBOL_GPL(rtl8366_vlan_prepare);