Commit 964201de authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller
Browse files

net/sched: Use fallthrough pseudo-keyword 

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through



Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 535094a0

net/sched/act_csum.c

+2 −1
Original line number Diff line number Diff line
@@ -598,7 +598,8 @@ static int tcf_csum_act(struct sk_buff *skb, const struct tc_action *a, 
		if (!tcf_csum_ipv6(skb, update_flags))

			goto drop;

		break;

	case cpu_to_be16(ETH_P_8021AD): /* fall through */

	case cpu_to_be16(ETH_P_8021AD):

		fallthrough;

	case cpu_to_be16(ETH_P_8021Q):

		if (skb_vlan_tag_present(skb) && !orig_vlan_tag_present) {

			protocol = skb->protocol;

net/sched/act_ct.c

+1 −1
Original line number Diff line number Diff line
@@ -783,7 +783,7 @@ static int ct_nat_execute(struct sk_buff *skb, struct nf_conn *ct, 
			}

		}

		/* Non-ICMP, fall thru to initialize if needed. */

		/* fall through */

		fallthrough;

	case IP_CT_NEW:

		/* Seen it before?  This can happen for loopback, retrans,

		 * or local packets.

net/sched/sch_cbq.c

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ cbq_classify(struct sk_buff *skb, struct Qdisc *sch, int *qerr) 
		case TC_ACT_STOLEN:

		case TC_ACT_TRAP:

			*qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN;

			/* fall through */

			fallthrough;

		case TC_ACT_SHOT:

			return NULL;

		case TC_ACT_RECLASSIFY:

net/sched/sch_drr.c

+1 −1
Original line number Diff line number Diff line
@@ -324,7 +324,7 @@ static struct drr_class *drr_classify(struct sk_buff *skb, struct Qdisc *sch, 
		case TC_ACT_STOLEN:

		case TC_ACT_TRAP:

			*qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN;

			/* fall through */

			fallthrough;

		case TC_ACT_SHOT:

			return NULL;

		}

net/sched/sch_ets.c

+1 −1
Original line number Diff line number Diff line
@@ -397,7 +397,7 @@ static struct ets_class *ets_classify(struct sk_buff *skb, struct Qdisc *sch, 
		case TC_ACT_QUEUED:

		case TC_ACT_TRAP:

			*qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN;

			/* fall through */

			fallthrough;

		case TC_ACT_SHOT:

			return NULL;

		}