Commit 963b2e8c authored by Lucas Stach's avatar Lucas Stach
Browse files

drm/etnaviv: fix reference leak when mmaping imported buffer 



drm_gem_prime_mmap() takes a reference on the GEM object, but before that
drm_gem_mmap_obj() already takes a reference, which will be leaked as only
one reference is dropped when the mapping is closed. Drop the extra
reference when dma_buf_mmap() succeeds.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarChristian Gmeiner <christian.gmeiner@gmail.com>
parent fe15c26e

drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c

+9 −1
Original line number Diff line number Diff line
@@ -91,7 +91,15 @@ static void *etnaviv_gem_prime_vmap_impl(struct etnaviv_gem_object *etnaviv_obj) 
static int etnaviv_gem_prime_mmap_obj(struct etnaviv_gem_object *etnaviv_obj,

		struct vm_area_struct *vma)

{

	return dma_buf_mmap(etnaviv_obj->base.dma_buf, vma, 0);

	int ret;



	ret = dma_buf_mmap(etnaviv_obj->base.dma_buf, vma, 0);

	if (!ret) {

		/* Drop the reference acquired by drm_gem_mmap_obj(). */

		drm_gem_object_put(&etnaviv_obj->base);

	}



	return ret;

}



static const struct etnaviv_gem_ops etnaviv_gem_prime_ops = {