Commit 96216181 authored by YueHaibing's avatar YueHaibing Committed by Jakub Kicinski
Browse files

sfp: Fix error handing in sfp_probe() 



gpiod_to_irq() never return 0, but returns negative in
case of error, check it and set gpio_irq to 0.

Fixes: 73970055 ("sfp: add SFP module support")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1d850493

drivers/net/phy/sfp.c

+2 −1
Original line number Diff line number Diff line
@@ -2389,7 +2389,8 @@ static int sfp_probe(struct platform_device *pdev) 
			continue;



		sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]);

		if (!sfp->gpio_irq[i]) {

		if (sfp->gpio_irq[i] < 0) {

			sfp->gpio_irq[i] = 0;

			sfp->need_poll = true;

			continue;

		}