Commit 9620a78f authored by Osama Muhammad's avatar Osama Muhammad Committed by Jiri Kosina
Browse files

HID: hid-wiimote-debug.c: Drop error checking for debugfs_create_file 

This patch removes the error checking for debugfs_create_file
in hid-wiimote-debug.c.c. This is because the debugfs_create_file()
does not return NULL but an ERR_PTR after an error.
The DebugFS kernel API is developed in a way that the
caller can safely ignore the errors that occur during
the creation of DebugFS nodes.The debugfs Api handles
it gracefully. The check is unnecessary.

Link to the comment above debugfs_create_file:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L451



Signed-off-by: default avatarOsama Muhammad <osmtendev@gmail.com>
Reviewed-by: default avatarDavid Rheinsberg <david@readahead.eu>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 1d754604

drivers/hid/hid-wiimote-debug.c

+0 −10
Original line number Diff line number Diff line
@@ -173,7 +173,6 @@ int wiidebug_init(struct wiimote_data *wdata) 
{

	struct wiimote_debug *dbg;

	unsigned long flags;

	int ret = -ENOMEM;



	dbg = kzalloc(sizeof(*dbg), GFP_KERNEL);

	if (!dbg)
@@ -183,13 +182,9 @@ int wiidebug_init(struct wiimote_data *wdata) 


	dbg->eeprom = debugfs_create_file("eeprom", S_IRUSR,

		dbg->wdata->hdev->debug_dir, dbg, &wiidebug_eeprom_fops);

	if (!dbg->eeprom)

		goto err;



	dbg->drm = debugfs_create_file("drm", S_IRUSR,

			dbg->wdata->hdev->debug_dir, dbg, &wiidebug_drm_fops);

	if (!dbg->drm)

		goto err_drm;



	spin_lock_irqsave(&wdata->state.lock, flags);

	wdata->debug = dbg;
@@ -197,11 +192,6 @@ int wiidebug_init(struct wiimote_data *wdata) 


	return 0;



err_drm:

	debugfs_remove(dbg->eeprom);

err:

	kfree(dbg);

	return ret;

}



void wiidebug_deinit(struct wiimote_data *wdata)