Commit 95f18760 authored by Beau Belgrave's avatar Beau Belgrave Committed by Steven Rostedt (Google)
Browse files

tracing/user_events: Use WRITE instead of READ for io vector import 

import_single_range expects the direction/rw to be where it came from,
not the protection/limit. Since the import is in a write path use WRITE.

Link: https://lkml.kernel.org/r/20220728233309.1896-3-beaub@linux.microsoft.com
Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/



Reported-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarBeau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 9cbf1234

kernel/trace/trace_events_user.c

+2 −1
Original line number Diff line number Diff line
@@ -1245,7 +1245,8 @@ static ssize_t user_events_write(struct file *file, const char __user *ubuf, 
	if (unlikely(*ppos != 0))

		return -EFAULT;



	if (unlikely(import_single_range(READ, (char *)ubuf, count, &iov, &i)))

	if (unlikely(import_single_range(WRITE, (char __user *)ubuf,

					 count, &iov, &i)))

		return -EFAULT;



	return user_events_write_core(file, &i);