Commit 95ea2efb authored by Brendan Cunningham's avatar Brendan Cunningham Committed by Jason Gunthorpe
Browse files

IB/hfi1: Remove unused struct mmu_rb_ops fields .insert, .invalidate 

The struct mmu_rb_ops function pointers .insert, .invalidate were only
used to increment and decrement struct sdma_mmu_node.refcount.

With the deletion of struct sdma_mmu_node.refcount and the addition of
struct mmu_rb_node.refcount  these function pointers are not called and
there are no implementations of them. So it is safe to delete these from
struct mmu_rb_ops.

Link: https://lore.kernel.org/r/168451526508.3702129.8677714753157495310.stgit@awfm-02.cornelisnetworks.com


Signed-off-by: default avatarBrendan Cunningham <bcunningham@cornelisnetworks.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent e236e2ea

drivers/infiniband/hw/hfi1/mmu_rb.h

+1 −6
Original line number Diff line number Diff line
@@ -19,16 +19,11 @@ struct mmu_rb_node { 
	struct kref refcount;

};



/*

 * NOTE: filter, insert, invalidate, and evict must not sleep.  Only remove is

 * allowed to sleep.

 */

/* filter and evict must not sleep. Only remove is allowed to sleep. */

struct mmu_rb_ops {

	bool (*filter)(struct mmu_rb_node *node, unsigned long addr,

		       unsigned long len);

	int (*insert)(void *ops_arg, struct mmu_rb_node *mnode);

	void (*remove)(void *ops_arg, struct mmu_rb_node *mnode);

	int (*invalidate)(void *ops_arg, struct mmu_rb_node *node);

	int (*evict)(void *ops_arg, struct mmu_rb_node *mnode,

		     void *evict_arg, bool *stop);

};