Commit 95dc85db authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda: conexant: Turn off EAPD at suspend, too 

Conexant codecs have a workaround for the noise at shutdown to turn
off EAPD, but it wasn't applied at suspend.  In the later patch, we'll
switch from reboot_notify callback to the general suspend-at-shutdown,
so let's apply the workaround to the suspend case, too.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214045
Link: https://lore.kernel.org/r/20210813081230.4268-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 81be1093

sound/pci/hda/patch_conexant.c

+15 −1
Original line number Diff line number Diff line
@@ -177,13 +177,18 @@ static int cx_auto_init(struct hda_codec *codec) 
	return 0;

}



static void cx_auto_reboot_notify(struct hda_codec *codec)

static void cx_auto_shutdown(struct hda_codec *codec)

{

	struct conexant_spec *spec = codec->spec;



	/* Turn the problematic codec into D3 to avoid spurious noises

	   from the internal speaker during (and after) reboot */

	cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);

}



static void cx_auto_reboot_notify(struct hda_codec *codec)

{

	cx_auto_shutdown(codec);

	snd_hda_gen_reboot_notify(codec);

}
@@ -193,6 +198,14 @@ static void cx_auto_free(struct hda_codec *codec) 
	snd_hda_gen_free(codec);

}



#ifdef CONFIG_PM

static int cx_auto_suspend(struct hda_codec *codec)

{

	cx_auto_shutdown(codec);

	return 0;

}

#endif



static const struct hda_codec_ops cx_auto_patch_ops = {

	.build_controls = snd_hda_gen_build_controls,

	.build_pcms = snd_hda_gen_build_pcms,
@@ -201,6 +214,7 @@ static const struct hda_codec_ops cx_auto_patch_ops = { 
	.free = cx_auto_free,

	.unsol_event = snd_hda_jack_unsol_event,

#ifdef CONFIG_PM

	.suspend = cx_auto_suspend,

	.check_power_status = snd_hda_gen_check_power_status,

#endif

};