Commit 95cec14b authored by Hao Luo's avatar Hao Luo Committed by Alexei Starovoitov
Browse files

selftests/bpf: Fix check in global_data_init. 



The returned value of bpf_object__open_file() should be checked with
libbpf_get_error() rather than NULL. This fix prevents test_progs from
crash when test_global_data.o is not present.

Signed-off-by: default avatarHao Luo <haoluo@google.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Acked-by: default avatarAndrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200903200528.747884-1-haoluo@google.com
parent b4ff7ad7

tools/testing/selftests/bpf/prog_tests/global_data_init.c

+2 −1
Original line number Diff line number Diff line
@@ -12,7 +12,8 @@ void test_global_data_init(void) 
	size_t sz;



	obj = bpf_object__open_file(file, NULL);

	if (CHECK_FAIL(!obj))

	err = libbpf_get_error(obj);

	if (CHECK_FAIL(err))

		return;



	map = bpf_object__find_map_by_name(obj, "test_glo.rodata");