Commit 95b065bf authored by Jim Mattson's avatar Jim Mattson Committed by Paolo Bonzini
Browse files

KVM: x86/pmu: Use different raw event masks for AMD and Intel 



The third nybble of AMD's event select overlaps with Intel's IN_TX and
IN_TXCP bits. Therefore, we can't use AMD64_RAW_EVENT_MASK on Intel
platforms that support TSX.

Declare a raw_event_mask in the kvm_pmu structure, initialize it in
the vendor-specific pmu_refresh() functions, and use that mask for
PERF_TYPE_RAW configurations in reprogram_gp_counter().

Fixes: 710c4765 ("KVM: x86/pmu: Use AMD64_RAW_EVENT_MASK for PERF_TYPE_RAW")
Signed-off-by: default avatarJim Mattson <jmattson@google.com>
Message-Id: <20220308012452.3468611-1-jmattson@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent df06dae3

arch/x86/include/asm/kvm_host.h

+1 −0
Original line number Diff line number Diff line
@@ -511,6 +511,7 @@ struct kvm_pmu { 
	u64 global_ctrl_mask;

	u64 global_ovf_ctrl_mask;

	u64 reserved_bits;

	u64 raw_event_mask;

	u8 version;

	struct kvm_pmc gp_counters[INTEL_PMC_MAX_GENERIC];

	struct kvm_pmc fixed_counters[INTEL_PMC_MAX_FIXED];

arch/x86/kvm/pmu.c

+2 −1
Original line number Diff line number Diff line
@@ -185,6 +185,7 @@ void reprogram_gp_counter(struct kvm_pmc *pmc, u64 eventsel) 
	u32 type = PERF_TYPE_RAW;

	struct kvm *kvm = pmc->vcpu->kvm;

	struct kvm_pmu_event_filter *filter;

	struct kvm_pmu *pmu = vcpu_to_pmu(pmc->vcpu);

	bool allow_event = true;



	if (eventsel & ARCH_PERFMON_EVENTSEL_PIN_CONTROL)
@@ -221,7 +222,7 @@ void reprogram_gp_counter(struct kvm_pmc *pmc, u64 eventsel) 
	}



	if (type == PERF_TYPE_RAW)

		config = eventsel & AMD64_RAW_EVENT_MASK;

		config = eventsel & pmu->raw_event_mask;



	if (pmc->current_config == eventsel && pmc_resume_counter(pmc))

		return;

arch/x86/kvm/svm/pmu.c

+1 −0
Original line number Diff line number Diff line
@@ -284,6 +284,7 @@ static void amd_pmu_refresh(struct kvm_vcpu *vcpu) 


	pmu->counter_bitmask[KVM_PMC_GP] = ((u64)1 << 48) - 1;

	pmu->reserved_bits = 0xfffffff000280000ull;

	pmu->raw_event_mask = AMD64_RAW_EVENT_MASK;

	pmu->version = 1;

	/* not applicable to AMD; but clean them to prevent any fall out */

	pmu->counter_bitmask[KVM_PMC_FIXED] = 0;

arch/x86/kvm/vmx/pmu_intel.c

+1 −0
Original line number Diff line number Diff line
@@ -485,6 +485,7 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu) 
	pmu->counter_bitmask[KVM_PMC_FIXED] = 0;

	pmu->version = 0;

	pmu->reserved_bits = 0xffffffff00200000ull;

	pmu->raw_event_mask = X86_RAW_EVENT_MASK;



	entry = kvm_find_cpuid_entry(vcpu, 0xa, 0);

	if (!entry || !vcpu->kvm->arch.enable_pmu)