Commit 95939551 authored by Luca Coelho's avatar Luca Coelho
Browse files

iwlwifi: add GNSS differentiation to the device tables 



Devices that also include a GNSS module have different names, so add a
new device option to differentiate them, according to the values we
have in the modules section of the subsystem device ID.

Additionally, convert the two applicable devices to use this value
instead of hardcoded subsystem IDs.

Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200309091348.1f958e558d05.I45492bb57cbbeb4cc0ec84313bade4def7377a27@changeid
parent d6f2134a

drivers/net/wireless/intel/iwlwifi/cfg/9000.c

+1 −0
Original line number Diff line number Diff line
@@ -196,6 +196,7 @@ const char iwl9461_name[] = "Intel(R) Wireless-AC 9461"; 
const char iwl9462_name[] = "Intel(R) Wireless-AC 9462";

const char iwl9560_name[] = "Intel(R) Wireless-AC 9560";

const char iwl9260_160_name[] = "Intel(R) Wireless-AC 9260 160MHz";

const char iwl9270_160_name[] = "Intel(R) Wireless-AC 9270 160MHz";

const char iwl9560_160_name[] = "Intel(R) Wireless-AC 9560 160MHz";



const char iwl9260_killer_1550_name[] =

drivers/net/wireless/intel/iwlwifi/iwl-config.h

+6 −0
Original line number Diff line number Diff line
@@ -464,7 +464,11 @@ struct iwl_cfg { 
#define IWL_CFG_NO_160			0x0

#define IWL_CFG_160			0x1



#define IWL_CFG_CORES_BT		0x0

#define IWL_CFG_CORES_BT_GNSS		0x5



#define IWL_SUBDEVICE_NO_160(subdevice)	((u16)((subdevice) & 0x0100) >> 9)

#define IWL_SUBDEVICE_CORES(subdevice)	((u16)((subdevice) & 0x1C00) >> 10)



struct iwl_dev_info {

	u16 device;
@@ -472,6 +476,7 @@ struct iwl_dev_info { 
	u16 mac_type;

	u16 rf_type;

	u8 no_160;

	u8 cores;

	const struct iwl_cfg *cfg;

	const char *name;

};
@@ -486,6 +491,7 @@ extern const char iwl9461_name[]; 
extern const char iwl9462_name[];

extern const char iwl9560_name[];

extern const char iwl9260_160_name[];

extern const char iwl9270_160_name[];

extern const char iwl9560_160_name[];

extern const char iwl9260_killer_1550_name[];

extern const char iwl9560_killer_1550i_name[];

drivers/net/wireless/intel/iwlwifi/pcie/drv.c

+18 −7
Original line number Diff line number Diff line
@@ -942,20 +942,17 @@ static const struct pci_device_id iwl_hw_card_ids[] = { 
MODULE_DEVICE_TABLE(pci, iwl_hw_card_ids);



#define _IWL_DEV_INFO(_device, _subdevice, _mac_type, _rf_type, _no_160,   \

		      _cfg, _name)					   \

		      _cores, _cfg, _name)				   \

	{ .device = (_device), .subdevice = (_subdevice), .cfg = &(_cfg),  \

	  .name = _name, .mac_type = _mac_type, .rf_type = _rf_type,	   \

	  .no_160 = _no_160, }

	  .no_160 = _no_160, .cores = _cores }



#define IWL_DEV_INFO(_device, _subdevice, _cfg, _name) \

	_IWL_DEV_INFO(_device, _subdevice, IWL_CFG_ANY, IWL_CFG_ANY,	\

		      IWL_CFG_ANY, _cfg, _name)

		      IWL_CFG_ANY, IWL_CFG_ANY, _cfg, _name)



static const struct iwl_dev_info iwl_dev_info_table[] = {

#if IS_ENABLED(CONFIG_IWLMVM)

	IWL_DEV_INFO(0x2526, 0x1410, iwl9260_2ac_cfg, iwl9270_name),

	IWL_DEV_INFO(0x2526, 0x1610, iwl9260_2ac_cfg, iwl9270_name),



	IWL_DEV_INFO(0x2526, 0x1550, iwl9260_2ac_cfg, iwl9260_killer_1550_name),



	IWL_DEV_INFO(0x2526, 0x0030, iwl9560_2ac_cfg, iwl9560_160_name),
@@ -991,9 +988,20 @@ static const struct iwl_dev_info iwl_dev_info_table[] = { 


	_IWL_DEV_INFO(0x2526, IWL_CFG_ANY,

		      IWL_CFG_MAC_TYPE_TH, IWL_CFG_RF_TYPE_TH, IWL_CFG_160,

		      IWL_CFG_CORES_BT_GNSS,

		      iwl9260_2ac_cfg, iwl9270_160_name),

	_IWL_DEV_INFO(0x2526, IWL_CFG_ANY,

		      IWL_CFG_MAC_TYPE_TH, IWL_CFG_RF_TYPE_TH, IWL_CFG_NO_160,

		      IWL_CFG_CORES_BT_GNSS,

		      iwl9260_2ac_cfg, iwl9270_name),



	_IWL_DEV_INFO(0x2526, IWL_CFG_ANY,

		      IWL_CFG_MAC_TYPE_TH, IWL_CFG_RF_TYPE_TH, IWL_CFG_160,

		      IWL_CFG_CORES_BT,

		      iwl9260_2ac_cfg, iwl9260_160_name),

	_IWL_DEV_INFO(0x2526, IWL_CFG_ANY,

		      IWL_CFG_MAC_TYPE_TH, IWL_CFG_RF_TYPE_TH, IWL_CFG_NO_160,

		      IWL_CFG_CORES_BT,

		      iwl9260_2ac_cfg, iwl9260_name),

#endif /* CONFIG_IWLMVM */

};
@@ -1046,7 +1054,10 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		     CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id)) &&

		    (dev_info->no_160 == (u8)IWL_CFG_ANY ||

		     dev_info->no_160 ==

		     IWL_SUBDEVICE_NO_160(pdev->subsystem_device))) {

		     IWL_SUBDEVICE_NO_160(pdev->subsystem_device)) &&

		    (dev_info->cores == (u8)IWL_CFG_ANY ||

		     dev_info->cores ==

		     IWL_SUBDEVICE_CORES(pdev->subsystem_device))) {

			iwl_trans->cfg = dev_info->cfg;

			iwl_trans->name = dev_info->name;

			goto found;