Unverified Commit 95856d1f authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

regmap: sdw: check for invalid multi-register writes config 



SoundWire code as it is only supports Bulk register writes and
it does not support multi-register writes.

Any drivers that set can_multi_write and use regmap_multi_reg_write() will
easily endup with programming the hardware incorrectly without any errors.

So, add this check in bus code to be able to validate the drivers config.

Fixes: 52227204 ("regmap: sdw: Remove 8-bit value size restriction")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230523154747.5429-1-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 39815141

drivers/base/regmap/regmap-sdw.c

+4 −0
Original line number Diff line number Diff line
@@ -59,6 +59,10 @@ static int regmap_sdw_config_check(const struct regmap_config *config) 
	if (config->pad_bits != 0)

		return -ENOTSUPP;



	/* Only bulk writes are supported not multi-register writes */

	if (config->can_multi_write)

		return -ENOTSUPP;



	return 0;

}