Commit 957e816e authored by Yang Yingliang's avatar Yang Yingliang Committed by Lipeng Sang
Browse files

ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev() 

stable inclusion
from stable-v5.10.153
commit ce6fd1c382a38b75557db85a2fe99d285540a03d
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I64YCA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ce6fd1c382a38b75557db85a2fe99d285540a03d



--------------------------------

[ Upstream commit 4a4c8482 ]

dev_set_name() in soundbus_add_one() allocates memory for name, it need be
freed when of_device_register() fails, call soundbus_dev_put() to give up
the reference that hold in device_initialize(), so that it can be freed in
kobject_cleanup() when the refcount hit to 0. And other resources are also
freed in i2sbus_release_dev(), so it can return 0 directly.

Fixes: f3d9478b ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221027013438.991920-1-yangyingliang@huawei.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLipeng Sang <sanglipeng1@jd.com>
parent 5251cbff

sound/aoa/soundbus/i2sbus/core.c

+4 −0
Original line number Diff line number Diff line
@@ -302,6 +302,10 @@ static int i2sbus_add_dev(struct macio_dev *macio, 


	if (soundbus_add_one(&dev->sound)) {

		printk(KERN_DEBUG "i2sbus: device registration error!\n");

		if (dev->sound.ofdev.dev.kobj.state_initialized) {

			soundbus_dev_put(&dev->sound);

			return 0;

		}

		goto err;

	}