Commit 956c3ae4 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: hns3: fix a double shift bug 



These flags are used to set and test bits like this:

	if (!test_bit(HCLGE_PTP_FLAG_TX_EN, &ptp->flags) ||

The issue is that test_bit() takes a bit number like 1, but we are
passing BIT(1) instead and it's testing BIT(BIT(1)).  This does not
cause a problem because it is always done consistently and the bit
values are very small.

Fixes: 0bf5eb78 ("net: hns3: add support for PTP")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent faebad85

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.h

+3 −3
Original line number Diff line number Diff line
@@ -43,9 +43,9 @@ 
#define HCLGE_PTP_SEC_H_OFFSET		32u

#define HCLGE_PTP_SEC_L_MASK		GENMASK(31, 0)



#define HCLGE_PTP_FLAG_EN		BIT(0)

#define HCLGE_PTP_FLAG_TX_EN		BIT(1)

#define HCLGE_PTP_FLAG_RX_EN		BIT(2)

#define HCLGE_PTP_FLAG_EN		0

#define HCLGE_PTP_FLAG_TX_EN		1

#define HCLGE_PTP_FLAG_RX_EN		2



struct hclge_ptp {

	struct hclge_dev *hdev;