Commit 9569ff1a authored by Dan Carpenter's avatar Dan Carpenter Committed by Ville Syrjälä
Browse files

drm/i915: Fix error code in icl_compute_combo_phy_dpll() 



This function is supposed to return zero or negative error codes but it
accidentally returns true on failure.

Fixes: 92a02074 ("drm/i915: Split shared dpll .get_dplls() into compute and get phases")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/YrVcHArNMTGCSy+9@kili


Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
parent f7fb92cd

drivers/gpu/drm/i915/display/intel_dpll_mgr.c

+1 −1
Original line number Diff line number Diff line
@@ -3184,7 +3184,7 @@ static int icl_compute_combo_phy_dpll(struct intel_atomic_state *state, 
	struct icl_port_dpll *port_dpll =

		&crtc_state->icl_port_dplls[ICL_PORT_DPLL_DEFAULT];

	struct skl_wrpll_params pll_params = {};

	bool ret;

	int ret;



	if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI) ||

	    intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))