Commit 9553b62c authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by David S. Miller
Browse files

net: atlantic: Use readx_poll_timeout() for large timeout 



Commit
   8dcf2ad3 ("net: atlantic: add hwmon getter for MAC temperature")

implemented a read callback with an udelay(10000U). This fails to
compile on ARM because the delay is >1ms. I doubt that it is needed to
spin for 10ms even if possible on x86.

>From looking at the code, the context appears to be preemptible so using
usleep() should work and avoid busy spinning.

Use readx_poll_timeout() in the poll loop.

Fixes: 8dcf2ad3 ("net: atlantic: add hwmon getter for MAC temperature")
Cc: Mark Starovoytov <mstarovoitov@marvell.com>
Cc: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <sebastian@breakpoint.cc>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 957ff427

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c

+2 −2
Original line number Diff line number Diff line
@@ -1631,8 +1631,8 @@ static int hw_atl_b0_get_mac_temp(struct aq_hw_s *self, u32 *temp) 
		hw_atl_ts_reset_set(self, 0);

	}



	err = readx_poll_timeout_atomic(hw_atl_b0_ts_ready_and_latch_high_get,

					self, val, val == 1, 10000U, 500000U);

	err = readx_poll_timeout(hw_atl_b0_ts_ready_and_latch_high_get, self,

				 val, val == 1, 10000U, 500000U);

	if (err)

		return err;