Commit 954445c7 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: samsung: Drop redundant node parameter in samsung_banks_of_node_get() 



The node is taken from the device pointer, which is supplied as a parameter,
hence no need to have a separate parameter for node. Drop redundant node
parameter in samsung_banks_of_node_get().

While at it, drop "of_" part in the samsung_banks_of_node_get() and
samsung_banks_of_node_put() function names to avoid additional churn
in the next changes.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent 0173ce55

drivers/pinctrl/samsung/pinctrl-samsung.c

+5 −7
Original line number Diff line number Diff line
@@ -1002,7 +1002,7 @@ samsung_pinctrl_get_soc_data_for_of_alias(struct platform_device *pdev) 
	return &(of_data->ctrl[id]);

}



static void samsung_banks_of_node_put(struct samsung_pinctrl_drv_data *d)

static void samsung_banks_node_put(struct samsung_pinctrl_drv_data *d)

{

	struct samsung_pin_bank *bank;

	unsigned int i;
@@ -1016,12 +1016,11 @@ static void samsung_banks_of_node_put(struct samsung_pinctrl_drv_data *d) 
 * Iterate over all driver pin banks to find one matching the name of node,

 * skipping optional "-gpio" node suffix. When found, assign node to the bank.

 */

static void samsung_banks_of_node_get(struct device *dev,

				      struct samsung_pinctrl_drv_data *d,

				      struct device_node *node)

static void samsung_banks_node_get(struct device *dev, struct samsung_pinctrl_drv_data *d)

{

	const char *suffix = "-gpio-bank";

	struct samsung_pin_bank *bank;

	struct device_node *node = dev->of_node;

	struct device_node *child;

	/* Pin bank names are up to 4 characters */

	char node_name[20];
@@ -1061,7 +1060,6 @@ static const struct samsung_pin_ctrl * 
samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,

			     struct platform_device *pdev)

{

	struct device_node *node = pdev->dev.of_node;

	const struct samsung_pin_bank_data *bdata;

	const struct samsung_pin_ctrl *ctrl;

	struct samsung_pin_bank *bank;
@@ -1125,7 +1123,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d, 
	 */

	d->virt_base = virt_base[0];



	samsung_banks_of_node_get(&pdev->dev, d, node);

	samsung_banks_node_get(&pdev->dev, d);



	d->pin_base = pin_base;

	pin_base += d->nr_pins;
@@ -1186,7 +1184,7 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) 
err_unregister:

	samsung_pinctrl_unregister(pdev, drvdata);

err_put_banks:

	samsung_banks_of_node_put(drvdata);

	samsung_banks_node_put(drvdata);

	return ret;

}