Commit 95073b72 authored Mar 24, 2022 by Jakob Koschel Committed by Viresh Kumar Apr 11, 2022

opp: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/


Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent 543256d2

drivers/opp/core.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -1486,9 +1486,8 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_put);
		*/
		void dev_pm_opp_remove(struct device *dev, unsigned long freq)
		{
		struct dev_pm_opp *opp;
		struct dev_pm_opp opp = NULL, iter;
		struct opp_table *opp_table;
		bool found = false;

		opp_table = _find_opp_table(dev);
		if (IS_ERR(opp_table))
		@@ -1496,16 +1495,16 @@ void dev_pm_opp_remove(struct device *dev, unsigned long freq)

		mutex_lock(&opp_table->lock);

		list_for_each_entry(opp, &opp_table->opp_list, node) {
		if (opp->rate == freq) {
		found = true;
		list_for_each_entry(iter, &opp_table->opp_list, node) {
		if (iter->rate == freq) {
		opp = iter;
		break;
		}
		}

		mutex_unlock(&opp_table->lock);

		if (found) {
		if (opp) {
		dev_pm_opp_put(opp);

		/* Drop the reference taken by dev_pm_opp_add() */