Unverified Commit 94c1ceb0 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda: Fix potential buffer overflow by snprintf() 



snprintf() returns the would-be-filled size when the string overflows
the given buffer size, hence using this value may result in the buffer
overflow (although it's unrealistic).

This patch replaces with a safer version, scnprintf() for papering
over such a potential issue.

Fixes: 29c8e439 ("ASoC: SOF: Intel: hda: add extended rom status dump to error log")
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20220801165420.25978-4-tiwai@suse.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1eb123ce

sound/soc/sof/intel/hda.c

+1 −1
Original line number Diff line number Diff line
@@ -574,7 +574,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, const char *le 
	chip = get_chip_info(sdev->pdata);

	for (i = 0; i < HDA_EXT_ROM_STATUS_SIZE; i++) {

		value = snd_sof_dsp_read(sdev, HDA_DSP_BAR, chip->rom_status_reg + i * 0x4);

		len += snprintf(msg + len, sizeof(msg) - len, " 0x%x", value);

		len += scnprintf(msg + len, sizeof(msg) - len, " 0x%x", value);

	}



	dev_printk(level, sdev->dev, "extended rom status: %s", msg);