Commit 94ba1c31 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: fix the name of value arg of devl_param_driverinit_value_get() 



Probably due to copy-paste error, the name of the arg is "init_val"
which is misleading, as the pointer is used to point to struct where to
store the current value. Rename it to "val" and change the arg comment
a bit on the way.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent afd888c3

include/net/devlink.h

+1 −1
Original line number Diff line number Diff line
@@ -1784,7 +1784,7 @@ void devlink_params_unregister(struct devlink *devlink, 
			       const struct devlink_param *params,

			       size_t params_count);

int devl_param_driverinit_value_get(struct devlink *devlink, u32 param_id,

				    union devlink_param_value *init_val);

				    union devlink_param_value *val);

void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id,

				     union devlink_param_value init_val);

void devl_param_value_changed(struct devlink *devlink, u32 param_id);

net/devlink/leftover.c

+4 −3
Original line number Diff line number Diff line
@@ -9629,13 +9629,14 @@ EXPORT_SYMBOL_GPL(devlink_params_unregister); 
 *

 *	@devlink: devlink

 *	@param_id: parameter ID

 *	@init_val: value of parameter in driverinit configuration mode

 *	@val: pointer to store the value of parameter in driverinit

 *	      configuration mode

 *

 *	This function should be used by the driver to get driverinit

 *	configuration for initialization after reload command.

 */

int devl_param_driverinit_value_get(struct devlink *devlink, u32 param_id,

				    union devlink_param_value *init_val)

				    union devlink_param_value *val)

{

	struct devlink_param_item *param_item;
@@ -9655,7 +9656,7 @@ int devl_param_driverinit_value_get(struct devlink *devlink, u32 param_id, 
						      DEVLINK_PARAM_CMODE_DRIVERINIT)))

		return -EOPNOTSUPP;



	*init_val = param_item->driverinit_value;

	*val = param_item->driverinit_value;



	return 0;

}