Commit 94ae1188 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

media: rzg2l-cru: fix a test for timeout 



The test for if the loop timed out is wrong and Smatch complains:

    drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:411 rzg2l_csi2_mipi_link_disable()
    warn: should this be 'timeout == -1'

Let's change it to a preop loop instead of a post op loop.

Fixes: 51e8415e ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent e54334cd

drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -402,7 +402,7 @@ static void rzg2l_csi2_mipi_link_disable(struct rzg2l_csi2 *csi2) 
	rzg2l_csi2_write(csi2, CSI2nRTCT, CSI2nRTCT_VSRST);

	rzg2l_csi2_write(csi2, CSI2nRTCT, CSI2nRTCT_VSRST);





	/* Make sure CSI2nRTST.VSRSTS bit is cleared */

	/* Make sure CSI2nRTST.VSRSTS bit is cleared */

	while (timeout--) {

	while (--timeout) {

		if (!(rzg2l_csi2_read(csi2, CSI2nRTST) & CSI2nRTST_VSRSTS))

		if (!(rzg2l_csi2_read(csi2, CSI2nRTST) & CSI2nRTST_VSRSTS))

			break;

			break;

		usleep_range(100, 200);

		usleep_range(100, 200);